feat(recruit): 내 공고 생성 모달 구현 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkrdmstlr3
requested review from
woo-jk,
Collection50 and
eunbeann
as code owners
woo-jk
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
이거 만들다가 만 코드입니다! 이후에 샤든 ui걷어내고 로직 교체하려구요!
woo-jk
reviewed
Aug 7, 2024
Comment on lines
+10
to
+21
| function Dialog({ open, children, onClose }: DialogProps) { | ||
| return ( | ||
| <RadixDialog.Root> | ||
| <RadixDialog.Portal> | ||
| <RadixDialog.Portal> | ||
| <RadixDialog.Overlay></RadixDialog.Overlay> | ||
| <RadixDialog.Content>{children}</RadixDialog.Content> | ||
| </RadixDialog.Portal> | ||
| </RadixDialog.Portal> | ||
| </RadixDialog.Root> | ||
| ); | ||
| } |
Collection50
reviewed
Aug 7, 2024
| <span className={clsx('text-label1', period === selectedPeriod ? 'text-neutral-30' : 'text-neutral-80')}> | ||
| {period} | ||
| </span> | ||
| {period === selectedPeriod ? <Icon size={16} name="check" color="#AEB0B6" /> : null} |
src/app/(sidebar)/my-recruit/components/NewRecruitDialogContent/NewRecruitDialogContent.tsx
Show resolved
Hide resolved
Comment on lines
12
to
14
| {required ? <div className="text-mint-40 text-label1">*</div> : null} | ||
| <input value={value} className="flex-1 outline-none bg-transparent" {...inputProps} /> | ||
| {right != null ? <div className="ml-[12px]">{right}</div> : null} |
| return ( | ||
| <div className="w-full flex justify-between items-center p-12 bg-neutral-1 border-neutral-20 rounded-[8px] border-[1px]"> | ||
| {required ? <div className="text-mint-40 text-label1">*</div> : null} | ||
| <input value={value} className="flex-1 outline-none bg-transparent" {...inputProps} /> |
There was a problem hiding this comment.
공통 Input 컴포넌트를 사용하시지 않은 이유가 있나요??
There was a problem hiding this comment.
컴포넌트명은 TextFiled인데 태그가 사용되고 있어서 혼란이 있을 수도 있다고 생각해요
textarea를 사용하거나 InputField라는 네이밍은 어떨까요??
There was a problem hiding this comment.
공통 Input 컴포넌트를 사용하시지 않은 이유가 있나요??
이 PR에는 input컴포넌트가 아직 없어요! 이후 교체하겠습니다!
textarea를 사용하거나 InputField라는 네이밍은 어떨까요??
회사에서 습관적으로 쓰다보니 습관적으로 쓰게 되었네요. 좋습니다!
|
|
||
| export default function MyRecruit() { | ||
| const [dialogOpened, setDialogOpened] = useState(false); |
Comment on lines
7
to
14
| fill-rule="evenodd" | ||
| clip-rule="evenodd" | ||
| d="M10.705 1.6194V0.273682H9.53137V3.83357H8.74898V1.6194H4.86048V0.273682H3.68689V3.83357H2.9045V1.6194H0.0957031V5.63308H13.9049V1.6194H10.705Z" | ||
| fill={color} | ||
| /> | ||
| <path | ||
| fill-rule="evenodd" | ||
| clip-rule="evenodd" |
There was a problem hiding this comment.
이 부분도 카멜 케이스로 해주시면 좋을 것 같아요~
There was a problem hiding this comment.
오 놓친부분 감사합니다!
f46c9ee 여기서 반영했어요
eunbeann
approved these changes
Aug 7, 2024
| <div className="w-full flex justify-between items-center p-12 bg-neutral-1 border-neutral-20 rounded-[8px] border-[1px]"> | ||
| {required ? <div className="text-mint-40 text-label1">*</div> : null} | ||
| <input value={value} className="flex-1 outline-none bg-transparent" {...inputProps} /> | ||
| {right != null ? <div className="ml-[12px]">{right}</div> : null} |
There was a problem hiding this comment.
잘 몰라서 여쭙는데, 보통 텍스트 필드 오른쪽에 표시되는 글자수 체킹 혹은 아이콘을 right라는 이름으로 짓는 것이 일반적인가요??
사용된 컴포넌트를 확인하고서 이 props의 역햘을 이해할 수 있었어서요!!
There was a problem hiding this comment.
들어가는 컴포넌트들이 통일되지않아 특정한 이름을 짓는 것이 어려워서 제너럴한 이름으로 가져가게 되었습니다!
|
리뷰주신 부분들 모두 반영해서 어프룹해보겠습니다! |
Collection50
pushed a commit
that referenced
this pull request
Aug 22, 2024
* feat(recruit): 내 공고 생성 모달 구현 * update
Collection50
added a commit
that referenced
this pull request
Aug 24, 2024
* feat * feat * 중복 처리 * fix * f * feat * feat(recruit): 내 공고 생성 모달 구현 (#20) * feat(recruit): 내 공고 생성 모달 구현 * update * feat(editor): 에디터의 제목, 태그 구현 (#19) * feat * feat * 중복 처리 * fix * f * fix * import * fix * a * fix ui * fix * fix * fix * fix * fix * fix * fix * yarn * fix * fix * feat * feat * feat * feat * feat * fix * fix * f * fix * fix * f --------- Co-authored-by: shellboy <[email protected]>
eunbeann
pushed a commit
that referenced
this pull request
Aug 24, 2024
* feat * feat * 중복 처리 * fix * f * feat * feat(recruit): 내 공고 생성 모달 구현 (#20) * feat(recruit): 내 공고 생성 모달 구현 * update * feat(editor): 에디터의 제목, 태그 구현 (#19) * feat * feat * 중복 처리 * fix * f * fix * import * fix * a * fix ui * fix * fix * fix * fix * fix * fix * fix * yarn * fix * fix * feat * feat * feat * feat * feat * fix * fix * f * fix * fix * f --------- Co-authored-by: shellboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3. 관련 스크린샷을 첨부해주세요.
2024-08-04.4.34.28.mov
4. 완료 사항
5. 추가 사항 / 코드 리뷰 받고 싶은 부분